order-in-components.js 6.8 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222
  1. /**
  2. * @fileoverview Keep order of properties in components
  3. * @author Michał Sajnóg
  4. */
  5. 'use strict'
  6. const utils = require('../utils')
  7. const Traverser = require('eslint/lib/util/traverser')
  8. const defaultOrder = [
  9. 'el',
  10. 'name',
  11. 'parent',
  12. 'functional',
  13. ['delimiters', 'comments'],
  14. ['components', 'directives', 'filters'],
  15. 'extends',
  16. 'mixins',
  17. 'inheritAttrs',
  18. 'model',
  19. ['props', 'propsData'],
  20. 'data',
  21. 'computed',
  22. 'watch',
  23. 'LIFECYCLE_HOOKS',
  24. 'methods',
  25. ['template', 'render'],
  26. 'renderError'
  27. ]
  28. const groups = {
  29. LIFECYCLE_HOOKS: [
  30. 'beforeCreate',
  31. 'created',
  32. 'beforeMount',
  33. 'mounted',
  34. 'beforeUpdate',
  35. 'updated',
  36. 'activated',
  37. 'deactivated',
  38. 'beforeDestroy',
  39. 'destroyed'
  40. ]
  41. }
  42. function getOrderMap (order) {
  43. const orderMap = new Map()
  44. order.forEach((property, i) => {
  45. if (Array.isArray(property)) {
  46. property.forEach(p => orderMap.set(p, i))
  47. } else {
  48. orderMap.set(property, i)
  49. }
  50. })
  51. return orderMap
  52. }
  53. function isComma (node) {
  54. return node.type === 'Punctuator' && node.value === ','
  55. }
  56. const ARITHMETIC_OPERATORS = ['+', '-', '*', '/', '%', '**']
  57. const BITWISE_OPERATORS = ['&', '|', '^', '~', '<<', '>>', '>>>']
  58. const COMPARISON_OPERATORS = ['==', '!=', '===', '!==', '>', '>=', '<', '<=']
  59. const RELATIONAL_OPERATORS = ['in', 'instanceof']
  60. const ALL_BINARY_OPERATORS = [].concat(
  61. ARITHMETIC_OPERATORS,
  62. BITWISE_OPERATORS,
  63. COMPARISON_OPERATORS,
  64. RELATIONAL_OPERATORS
  65. )
  66. const LOGICAL_OPERATORS = ['&&', '||']
  67. /*
  68. * Result `true` if the node is sure that there are no side effects
  69. *
  70. * Currently known side effects types
  71. *
  72. * node.type === 'CallExpression'
  73. * node.type === 'NewExpression'
  74. * node.type === 'UpdateExpression'
  75. * node.type === 'AssignmentExpression'
  76. * node.type === 'TaggedTemplateExpression'
  77. * node.type === 'UnaryExpression' && node.operator === 'delete'
  78. *
  79. * @param {ASTNode} node target node
  80. * @param {Object} visitorKeys sourceCode.visitorKey
  81. * @returns {Boolean} no side effects
  82. */
  83. function isNotSideEffectsNode (node, visitorKeys) {
  84. let result = true
  85. new Traverser().traverse(node, {
  86. visitorKeys,
  87. enter (node, parent) {
  88. if (
  89. node.type === 'FunctionExpression' ||
  90. node.type === 'Identifier' ||
  91. node.type === 'Literal' ||
  92. // es2015
  93. node.type === 'ArrowFunctionExpression' ||
  94. node.type === 'TemplateElement'
  95. ) {
  96. // no side effects node
  97. this.skip()
  98. } else if (
  99. node.type !== 'Property' &&
  100. node.type !== 'ObjectExpression' &&
  101. node.type !== 'ArrayExpression' &&
  102. (node.type !== 'UnaryExpression' || ['!', '~', '+', '-', 'typeof'].indexOf(node.operator) < 0) &&
  103. (node.type !== 'BinaryExpression' || ALL_BINARY_OPERATORS.indexOf(node.operator) < 0) &&
  104. (node.type !== 'LogicalExpression' || LOGICAL_OPERATORS.indexOf(node.operator) < 0) &&
  105. node.type !== 'MemberExpression' &&
  106. node.type !== 'ConditionalExpression' &&
  107. // es2015
  108. node.type !== 'SpreadElement' &&
  109. node.type !== 'TemplateLiteral'
  110. ) {
  111. // Can not be sure that a node has no side effects
  112. result = false
  113. this.break()
  114. }
  115. }
  116. })
  117. return result
  118. }
  119. // ------------------------------------------------------------------------------
  120. // Rule Definition
  121. // ------------------------------------------------------------------------------
  122. module.exports = {
  123. meta: {
  124. docs: {
  125. description: 'enforce order of properties in components',
  126. category: 'recommended',
  127. url: 'https://github.com/vuejs/eslint-plugin-vue/blob/v4.7.1/docs/rules/order-in-components.md'
  128. },
  129. fixable: 'code', // null or "code" or "whitespace"
  130. schema: [
  131. {
  132. type: 'object',
  133. properties: {
  134. order: {
  135. type: 'array'
  136. }
  137. },
  138. additionalProperties: false
  139. }
  140. ]
  141. },
  142. create (context) {
  143. const options = context.options[0] || {}
  144. const order = options.order || defaultOrder
  145. const extendedOrder = order.map(property => groups[property] || property)
  146. const orderMap = getOrderMap(extendedOrder)
  147. const sourceCode = context.getSourceCode()
  148. function checkOrder (propertiesNodes, orderMap) {
  149. const properties = propertiesNodes
  150. .filter(property => property.type === 'Property')
  151. .map(property => property.key)
  152. properties.forEach((property, i) => {
  153. const propertiesAbove = properties.slice(0, i)
  154. const unorderedProperties = propertiesAbove
  155. .filter(p => orderMap.get(p.name) > orderMap.get(property.name))
  156. .sort((p1, p2) => orderMap.get(p1.name) > orderMap.get(p2.name))
  157. const firstUnorderedProperty = unorderedProperties[0]
  158. if (firstUnorderedProperty) {
  159. const line = firstUnorderedProperty.loc.start.line
  160. context.report({
  161. node: property,
  162. message: `The "{{name}}" property should be above the "{{firstUnorderedPropertyName}}" property on line {{line}}.`,
  163. data: {
  164. name: property.name,
  165. firstUnorderedPropertyName: firstUnorderedProperty.name,
  166. line
  167. },
  168. fix (fixer) {
  169. const propertyNode = property.parent
  170. const firstUnorderedPropertyNode = firstUnorderedProperty.parent
  171. const hasSideEffectsPossibility = propertiesNodes
  172. .slice(
  173. propertiesNodes.indexOf(firstUnorderedPropertyNode),
  174. propertiesNodes.indexOf(propertyNode) + 1
  175. )
  176. .some((property) => !isNotSideEffectsNode(property, sourceCode.visitorKeys))
  177. if (hasSideEffectsPossibility) {
  178. return undefined
  179. }
  180. const comma = sourceCode.getTokenAfter(propertyNode)
  181. const hasAfterComma = isComma(comma)
  182. const codeStart = sourceCode.getTokenBefore(propertyNode).range[1] // to include comments
  183. const codeEnd = hasAfterComma ? comma.range[1] : propertyNode.range[1]
  184. const propertyCode = sourceCode.text.slice(codeStart, codeEnd) + (hasAfterComma ? '' : ',')
  185. const insertTarget = sourceCode.getTokenBefore(firstUnorderedPropertyNode)
  186. // If we can upgrade requirements to `eslint@>4.1.0`, this code can be replaced by:
  187. // return [
  188. // fixer.removeRange([codeStart, codeEnd]),
  189. // fixer.insertTextAfter(insertTarget, propertyCode)
  190. // ]
  191. const insertStart = insertTarget.range[1]
  192. const newCode = propertyCode + sourceCode.text.slice(insertStart, codeStart)
  193. return fixer.replaceTextRange([insertStart, codeEnd], newCode)
  194. }
  195. })
  196. }
  197. })
  198. }
  199. return utils.executeOnVue(context, (obj) => {
  200. checkOrder(obj.properties, orderMap)
  201. })
  202. }
  203. }